All committers have signed the CLA.

Hi @bartek9007. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Should I include into PRs, strict types declaration and type hinting?

Code quality check showed that I have unused param, but it is required by interface implemented by parent class. Other implementations also not necessarily uses this param.
Errors from code sniffer are fixed.

@bartoszkubicki Thank you for your contribution. Can you please fix the failing tests? The unused parameter can probably be ignored.
edit: Is this a known issue that you fixed, or did you find the problem yourself? How did it come about? I'm not sure what problem this fixes.

@josefbehr How it can be ommited if property mappers should implement \Magento\Eav\Model\Entity\Setup\PropertyMapperInterface which has this argument required public function map(array $input, $entityTypeId);

@bartoszkubicki I meant you can ignore the warning about the unused parameter, not remove it :) What about my other questions?

@josefbehr I have added some changes, I hope that test failures will be gone.

@bartoszkubicki Looking good, thanks. Can you please answer my other questions, and suppress the warning about the unused variable?

@josefbehr Didn't notice your edit. I have faced this problem by myself. When adding product attribute programatically, search weight of attributes wasn't persisted to db (table catalog_eav_attribute), because of lacking mapping. Firstly I have fixed it in my current project, the decided to create pull request. I haven't found any issue about that - problem is not very serious, but tend to be annoying when you have to configure a lot of product attributes, and later you have to adjust search weight to requested values, despite of setting in initial script.

Hi @josefbehr, thank you for the review.
ENGCOM-4358 has been created to process this Pull Request

✔️ QA Passed

Hi @bartoszkubicki, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.